Fixed argument type in switchToIFrame() to be integer. #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
force-pushed
the
feature/fix-switch-to-iframe
branch
from
a8301e8
to
95f5a97
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
=========================================
Coverage 98.72% 98.72%
Complexity 374 374
=========================================
Files 24 24
Lines 1022 1022
=========================================
Hits 1009 1009
Misses 13 13 ☔ View full report in Codecov by Sentry. |
AlexSkrypnyk
added a commit
to civictheme/monorepo-drupal
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release
1.11.0introduced strict types.With that, the
switchToIFrame(string? $id)method started to fail on consumer projects usingw3c=truebecause the expected$idargument has a typestringinstead of expectedint.According to https://www.w3.org/TR/webdriver/#switch-to-frame, the
$idis expected to be an integer.This PR updates
string?withint?.Note that downstream project
MinkSelenium2Driverhave the same issue propagated after the recent release1.7.0: https://github.com/minkphp/MinkSelenium2Driver/blob/master/src/Selenium2Driver.php#L431